Differential D12125

Remove redundant administrator requirement from application edit policy page
ClosedPublic
Actions

Authored by epriestley on Mar 21 2015, 12:05 PM.

Tags

None

Referenced Files

	F14063622: D12125.diff
	Mon, Nov 18, 7:35 PM

	F14051884: D12125.diff
	Fri, Nov 15, 4:48 AM

	F14040761: D12125.diff
	Mon, Nov 11, 1:09 PM

	F14024143: D12125.diff
	Thu, Nov 7, 6:33 AM

	F13989098: D12125.id29169.diff
	Mon, Oct 21, 6:03 PM

	F13958516: D12125.id29151.diff
	Oct 14 2024, 3:14 PM

	Unknown Object (File)
	Oct 2 2024, 12:01 AM

	Unknown Object (File)
	Sep 4 2024, 3:49 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T7485: Clicking one specific greyed out button has no effect

Commits

Restricted Diffusion Commit
rP08aefafef75a: Remove redundant administrator requirement from application edit policy page

Summary

Fixes T7485. Before applications had proper policies, we gated access by requiring the viewer be an administrator.

This is now redundant (CAN_EDIT on applications has the same effect, and performs the same check), and may some day be wrong (we might let administrators configure a different policy to control who can configure applications). Today, it gets the policy dialog wrong.

Test Plan

Clicked "Edit Policies" as a non-administrator, was unable to, got nice error:

Screen_Shot_2015-03-21_at_5.05.21_AM.png (1×1 px, 146 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29151.Mar 21 2015, 12:05 PM

epriestley retitled this revision from to Remove redundant administrator requirement from application edit policy page.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7485: Clicking one specific greyed out button has no effect.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 21 2015, 12:05 PM

epriestley added inline comments.Mar 21 2015, 12:06 PM

src/applications/meta/controller/PhabricatorApplicationEditController.php
13–17	Specifically, this is the modern version of the check, which has the exact same effect.

btrahan accepted this revision.Mar 23 2015, 4:00 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 23 2015, 4:00 PM

Closed by commit rP08aefafef75a: Remove redundant administrator requirement from application edit policy page (authored by epriestley, committed by epriestley). · Explain WhyMar 23 2015, 4:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

meta/

controller/

PhabricatorApplicationEditController.php

4 lines

Diff 29169

src/applications/meta/controller/PhabricatorApplicationEditController.php

Loading...