Page MenuHomePhabricator

Fix improper selection of the chunk engine as a writable engine
ClosedPublic

Authored by epriestley on Mar 18 2015, 11:30 PM.
Tags
None
Referenced Files
F18741229: D12110.id.diff
Thu, Oct 2, 9:23 AM
F18737731: D12110.diff
Wed, Oct 1, 12:19 PM
F18618860: D12110.diff
Mon, Sep 15, 1:07 AM
F18612213: D12110.diff
Sun, Sep 14, 8:56 AM
F18597497: D12110.id29133.diff
Sat, Sep 13, 3:00 AM
F18590186: D12110.diff
Fri, Sep 12, 5:26 AM
F18587066: D12110.id29133.diff
Thu, Sep 11, 8:23 PM
F18505203: D12110.id.diff
Sep 5 2025, 12:28 AM
Subscribers

Details

Summary

Fixes T7621. The engine selection code started out making sense, but didn't make as much sense by the time I was done with it.

Specifically, from the vanilla file upload, we may incorrectly try to write directly to the chunk storage engine. This is incorrect, and produces a confusing/bad error.

Make chunk storage engines explicit and don't try to do single-file one-shot writes to them.

Test Plan
  • Tried to upload a large file with vanilla uploader, got better error message.
  • Uploaded small and large files with drag and drop.
  • Viewed FilesHelp/Options.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix improper selection of the chunk engine as a writable engine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 19 2015, 12:31 AM
This revision was automatically updated to reflect the committed changes.