Page MenuHomePhabricator

Fix improper selection of the chunk engine as a writable engine
ClosedPublic

Authored by epriestley on Mar 18 2015, 11:30 PM.
Tags
None
Referenced Files
F15461804: D12110.id29133.diff
Tue, Apr 1, 11:24 AM
F15459266: D12110.id.diff
Mon, Mar 31, 11:31 AM
F15458971: D12110.id29130.diff
Mon, Mar 31, 8:48 AM
F15457085: D12110.diff
Sun, Mar 30, 2:16 PM
F15401200: D12110.id29133.diff
Mon, Mar 17, 4:14 PM
F15380804: D12110.id29130.diff
Mar 14 2025, 4:31 AM
F15379604: D12110.id29130.diff
Mar 13 2025, 10:14 PM
F15336545: D12110.diff
Mar 8 2025, 7:28 PM
Subscribers

Details

Summary

Fixes T7621. The engine selection code started out making sense, but didn't make as much sense by the time I was done with it.

Specifically, from the vanilla file upload, we may incorrectly try to write directly to the chunk storage engine. This is incorrect, and produces a confusing/bad error.

Make chunk storage engines explicit and don't try to do single-file one-shot writes to them.

Test Plan
  • Tried to upload a large file with vanilla uploader, got better error message.
  • Uploaded small and large files with drag and drop.
  • Viewed FilesHelp/Options.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix improper selection of the chunk engine as a writable engine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 19 2015, 12:31 AM
This revision was automatically updated to reflect the committed changes.