Page MenuHomePhabricator

Fix improper selection of the chunk engine as a writable engine
ClosedPublic

Authored by epriestley on Mar 18 2015, 11:30 PM.
Tags
None
Referenced Files
F17632445: D12110.id29130.diff
Thu, Jul 10, 3:18 PM
F17630978: D12110.id29133.diff
Thu, Jul 10, 12:21 PM
F17608536: D12110.diff
Wed, Jul 9, 4:48 AM
Unknown Object (File)
Jun 2 2025, 9:53 AM
Unknown Object (File)
Jun 1 2025, 7:40 AM
Unknown Object (File)
May 7 2025, 9:57 PM
Unknown Object (File)
May 1 2025, 9:54 AM
Unknown Object (File)
Apr 30 2025, 12:10 PM
Subscribers

Details

Summary

Fixes T7621. The engine selection code started out making sense, but didn't make as much sense by the time I was done with it.

Specifically, from the vanilla file upload, we may incorrectly try to write directly to the chunk storage engine. This is incorrect, and produces a confusing/bad error.

Make chunk storage engines explicit and don't try to do single-file one-shot writes to them.

Test Plan
  • Tried to upload a large file with vanilla uploader, got better error message.
  • Uploaded small and large files with drag and drop.
  • Viewed FilesHelp/Options.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix improper selection of the chunk engine as a writable engine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 19 2015, 12:31 AM
This revision was automatically updated to reflect the committed changes.