Fix bad button construction in Owners
ClosedPublic
Actions

Authored by epriestley on Mar 18 2015, 10:37 AM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T7618: Owners application unable to enter into details of owned packages

Commits

Restricted Diffusion Commit
rPb5238dc080be: Fix bad button construction in Owners

Summary

Fixes T7618. The "button" needs to be a PHUIButtonView later on.

Test Plan

Forced condition, loaded page, saw button instead of fatal.

Diff Detail

Repository

rP Phabricator

Branch

audit1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4920
Build 4938: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29125.Mar 18 2015, 10:37 AM

epriestley retitled this revision from to Fix bad button construction in Owners.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, chad.

epriestley added a task: T7618: Owners application unable to enter into details of owned packages.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 18 2015, 10:37 AM

btrahan accepted this revision.Mar 18 2015, 2:07 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 18 2015, 2:07 PM

Closed by commit rPb5238dc080be: Fix bad button construction in Owners (authored by epriestley, committed by epriestley). · Explain WhyMar 18 2015, 2:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

owners/

controller/

PhabricatorOwnersDetailController.php

11 lines

Diff 29125

View Options

src/applications/owners/controller/PhabricatorOwnersDetailController.php

Fix bad button construction in OwnersClosedPublicActions