Page MenuHomePhabricator
Differential D12094

Add doclink for Diviner documentation
ClosedPublic
Actions

Authored by joshuaspence on Mar 17 2015, 11:32 AM.
Tags
None
Referenced Files
F14351497: D12094.id29095.diff
Thu, Dec 19, 7:50 AM
Unknown Object (File)
Sun, Dec 15, 10:26 PM
Unknown Object (File)
Tue, Dec 10, 10:42 AM
Unknown Object (File)
Sun, Dec 8, 1:20 AM
Unknown Object (File)
Thu, Dec 5, 5:37 PM
Unknown Object (File)
Mon, Dec 2, 3:06 AM
Unknown Object (File)
Sat, Nov 30, 2:11 PM
Unknown Object (File)
Fri, Nov 29, 6:55 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7502: Add doclink for Diviner
Commits
Restricted Diffusion Commit
rPcbaa2a508d87: Add doclink for Diviner documentation
Summary

Fixes T7502.

Test Plan

Went to /diviner/ and saw a link to the documentation at /help/documentation/PhabricatorDivinerApplication/.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5152
Build 5170: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29095.Mar 17 2015, 11:32 AM
joshuaspence retitled this revision from to Add doclink for Diviner documentation.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7502: Add doclink for Diviner.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMar 17 2015, 11:32 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley requested changes to this revision.Apr 4 2015, 12:01 PM
epriestley edited edge metadata.

This signature changed slightly (now getHelpDocumentationArticles() or similar). Happy to accept this with an actual test plan.

This revision now requires changes to proceed.Apr 4 2015, 12:01 PM
joshuaspence updated this revision to Diff 29527.Apr 6 2015, 12:28 PM
joshuaspence edited edge metadata.

Fix method name

joshuaspence edited the test plan for this revision. (Show Details)Apr 6 2015, 12:28 PM
joshuaspence edited edge metadata.
epriestley accepted this revision.Apr 6 2015, 1:30 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 6 2015, 1:30 PM
Closed by commit rPcbaa2a508d87: Add doclink for Diviner documentation (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 6 2015, 9:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diviner/
application/
9 lines

Diff 29527

View Options

src/applications/diviner/application/PhabricatorDivinerApplication.php

Loading...
Phabricator · Built by Phacility