Page MenuHomePhabricator
Differential D12094

Add doclink for Diviner documentation
ClosedPublic
Actions

Authored by joshuaspence on Mar 17 2015, 11:32 AM.
Tags
None
Referenced Files
F13210769: D12094.diff
Fri, May 17, 5:11 AM
F13196228: D12094.diff
Sun, May 12, 11:05 PM
F13190918: D12094.id.diff
Sat, May 11, 3:24 PM
Unknown Object (File)
Fri, May 3, 3:28 AM
Unknown Object (File)
Thu, May 2, 10:44 AM
Unknown Object (File)
Wed, May 1, 12:53 PM
Unknown Object (File)
Wed, May 1, 12:53 PM
Unknown Object (File)
Mon, Apr 29, 3:17 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7502: Add doclink for Diviner
Commits
Restricted Diffusion Commit
rPcbaa2a508d87: Add doclink for Diviner documentation
Summary

Fixes T7502.

Test Plan

Went to /diviner/ and saw a link to the documentation at /help/documentation/PhabricatorDivinerApplication/.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5152
Build 5170: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29095.Mar 17 2015, 11:32 AM
joshuaspence retitled this revision from to Add doclink for Diviner documentation.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7502: Add doclink for Diviner.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMar 17 2015, 11:32 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley requested changes to this revision.Apr 4 2015, 12:01 PM
epriestley edited edge metadata.

This signature changed slightly (now getHelpDocumentationArticles() or similar). Happy to accept this with an actual test plan.

This revision now requires changes to proceed.Apr 4 2015, 12:01 PM
joshuaspence updated this revision to Diff 29527.Apr 6 2015, 12:28 PM
joshuaspence edited edge metadata.

Fix method name

joshuaspence edited the test plan for this revision. (Show Details)Apr 6 2015, 12:28 PM
joshuaspence edited edge metadata.
epriestley accepted this revision.Apr 6 2015, 1:30 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 6 2015, 1:30 PM
Closed by commit rPcbaa2a508d87: Add doclink for Diviner documentation (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 6 2015, 9:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diviner/
application/
9 lines

Diff 29527

View Options

src/applications/diviner/application/PhabricatorDivinerApplication.php

Loading...
Phabricator · Built by Phacility