Page MenuHomePhabricator

Allow callers to explicitly request a progress bar redraw
ClosedPublic

Authored by epriestley on Mar 14 2015, 4:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 17, 7:39 PM
Unknown Object (File)
Thu, Nov 14, 7:34 AM
Unknown Object (File)
Wed, Nov 13, 8:29 PM
Unknown Object (File)
Sat, Nov 9, 6:35 PM
Unknown Object (File)
Fri, Nov 8, 9:09 PM
Unknown Object (File)
Tue, Nov 5, 11:55 PM
Unknown Object (File)
Sat, Nov 2, 7:57 AM
Unknown Object (File)
Sun, Oct 27, 7:55 PM
Subscribers

Details

Summary

Ref T7149. Normally, we only redraw the bar every 100ms.

When resuming large file uploads, we "complete" the first part of the file immediately, but it takes much less than 100ms, and then we may sit for the first chunk without updating. This is a little confusing. Allow a forced redraw so we can sit at "Resuming: 60%" or whatever instead.

Test Plan

See next diff.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow callers to explicitly request a progress bar redraw.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 15 2015, 6:08 PM
This revision was automatically updated to reflect the committed changes.