Page MenuHomePhabricator

Allow callers to explicitly request a progress bar redraw
ClosedPublic

Authored by epriestley on Mar 14 2015, 4:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 10, 3:21 AM
Unknown Object (File)
Sat, Mar 23, 12:46 PM
Unknown Object (File)
Feb 26 2024, 1:04 PM
Unknown Object (File)
Feb 3 2024, 2:32 AM
Unknown Object (File)
Feb 1 2024, 11:12 AM
Unknown Object (File)
Jan 31 2024, 9:52 AM
Unknown Object (File)
Jan 10 2024, 2:20 PM
Unknown Object (File)
Jan 6 2024, 12:37 PM
Subscribers

Details

Summary

Ref T7149. Normally, we only redraw the bar every 100ms.

When resuming large file uploads, we "complete" the first part of the file immediately, but it takes much less than 100ms, and then we may sit for the first chunk without updating. This is a little confusing. Allow a forced redraw so we can sit at "Resuming: 60%" or whatever instead.

Test Plan

See next diff.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow callers to explicitly request a progress bar redraw.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 15 2015, 6:08 PM
This revision was automatically updated to reflect the committed changes.