Page MenuHomePhabricator

Conpherence - finesse global upload vs conpherence durable column upload
ClosedPublic

Authored by btrahan on Mar 12 2015, 8:32 PM.
Tags
None
Referenced Files
F14827960: D12055.id29018.diff
Wed, Jan 29, 8:31 AM
F14825512: D12055.diff
Tue, Jan 28, 9:43 PM
Unknown Object (File)
Sun, Jan 26, 4:50 PM
Unknown Object (File)
Fri, Jan 24, 1:15 AM
Unknown Object (File)
Fri, Jan 24, 1:15 AM
Unknown Object (File)
Fri, Jan 24, 1:15 AM
Unknown Object (File)
Fri, Jan 24, 1:15 AM
Unknown Object (File)
Fri, Jan 24, 1:15 AM
Subscribers

Details

Summary

Fixes T7539. We need to set the "with-column" css class on the document body to make things like the jx-mask style-able. Also, make the global upload control only do it for the standard phabrcator page and not the document body.

Test Plan

dragged a file to conpherence column and it worked! uploaded a file to homepage with column open and it worked! uploaded a file to /file/ with column open and it worked!

Diff Detail

Repository
rP Phabricator
Branch
T7539
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4859
Build 4877: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Conpherence - finesse global upload vs conpherence durable column upload.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
epriestley edited edge metadata.

This will also affect the JX.Mask used by dialogs and lightboxes. I think those should be fine, but maybe double-check if you didn't?

This revision is now accepted and ready to land.Mar 12 2015, 8:33 PM
btrahan edited edge metadata.

scope mask so only global file upload mask gets adjusted by new css (nice catch epriestley!)

This revision was automatically updated to reflect the committed changes.