HomePhabricator

Modernize file storage engine selection

Description

Modernize file storage engine selection

Summary:
Fixes T5843. File storage engines use a very old "selector" mechanism which makes them difficult to extend.

This mechanism predates widespread use of PhutilSymbolLoader to discover available implementations at runtime. Runtime discovery has generally proven more flexible and easier to use than explicit selection (although it sometimes needs more UI to support it in cases where order or enabled/disabled flags can not be directly determined).

Use a modern runtime discovery mechanism instead of an explicit selector. This might break any installs which subclassed the Selector, but I believe almost no such installs exist, and they'll receive a meaningful exception upon upgrading (any custom engines will no longer implement all of the required methods).

Looking forward, this modernizes infrastructure to prepare for new "virtual" chunked-storage engines, with the eventual goal of supporting very large file uploads and data import into the Phacility cluster.

This uses D12051 to add UI to make it easier to understand the state of storage engines.

Test Plan:
Used new UI panel to assess storage engines:

Screen_Shot_2015-03-12_at_12.28.29_PM.png (195×1 px, 37 KB)

  • Uploaded a small file, saw it go to MySQL engine.
  • Uploaded a larger file, saw it go to S3 engine.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5843

Differential Revision: https://secure.phabricator.com/D12053

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Mar 12 2015, 8:28 PM
Reviewer
btrahan
Differential Revision
D12053: Modernize file storage engine selection
Parents
rP973079a7da3d: Modularize application configuration panels
Branches
Unknown
Tags
Unknown
Tasks
T5843: Make storage backends extensible