engine->isRelevantMessage expects forward slashes, but on Windows, Filesystem::readablePath returns backslashes.
Fixes T7527
Details
Details
- Reviewers
joshuaspence - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T7527: `arc lint` doesn't show lint warnings in powershell, cmd.exe, and git bash
Removed a semicolon from a js file, ran jshint linter on Windows via arc lint, saw warning.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- winpath
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 4837 Build 4853: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
I think the more correct behavior would be to fix ArcanistLintEngine::isRelevantMessage to use DIRECTORY_SEPARATOR instead of / on Windows (although it's not immediately clear to me what the problem is from looking at the code).