Page MenuHomePhabricator

Use forward slashes when collecting linted paths
Needs RevisionPublic

Authored by staticshock on Mar 11 2015, 2:39 PM.

Details

Summary

engine->isRelevantMessage expects forward slashes, but on Windows, Filesystem::readablePath returns backslashes.

Fixes T7527

Test Plan

Removed a semicolon from a js file, ran jshint linter on Windows via arc lint, saw warning.

Diff Detail

Repository
rARC Arcanist
Branch
winpath
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 4837
Build 4853: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

staticshock retitled this revision from to Use forward slashes when collecting linted paths.
staticshock updated this object.
staticshock edited the test plan for this revision. (Show Details)
joshuaspence edited edge metadata.

I think the more correct behavior would be to fix ArcanistLintEngine::isRelevantMessage to use DIRECTORY_SEPARATOR instead of / on Windows (although it's not immediately clear to me what the problem is from looking at the code).

This revision now requires changes to proceed.May 5 2015, 8:53 AM