Page MenuHomePhabricator

Further improve line grouping in unified views
ClosedPublic

Authored by epriestley on Mar 6 2015, 1:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 12, 6:14 PM
Unknown Object (File)
Sun, Mar 10, 7:15 AM
Unknown Object (File)
Wed, Mar 6, 4:43 PM
Unknown Object (File)
Tue, Mar 5, 6:06 PM
Unknown Object (File)
Sun, Mar 3, 2:04 PM
Unknown Object (File)
Sun, Mar 3, 1:39 PM
Unknown Object (File)
Feb 13 2024, 4:22 PM
Unknown Object (File)
Jan 24 2024, 4:28 PM
Subscribers

Details

Summary

Ref T2009. This tweaks things a bit more to improve consecuitive groups of added and removed lines.

Generally, it gives us "old, old, old, new, new, new" intead of "old, new, old, new, old, new".

Feelin' real good about having unit tests for this stuff.

Test Plan

Unit tests, looked at diffs in web UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Further improve line grouping in unified views.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Fix lint and tests, trailing whitespace removal threw a wrench into things.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 6 2015, 5:36 PM
This revision was automatically updated to reflect the committed changes.