Differential D11967

Support VHDL file extension in pygments
ClosedPublic
Actions

Authored by epriestley on Mar 4 2015, 3:37 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T7456: Syntax highlighting for VHDL files not working

Commits

rPHUeaa6ebecef8e: Support VHDL file extension in pygments

Summary

Fixes T7456. See that task for some additional discussion.

Test Plan

Read carefully.

Diff Detail

Repository

rPHU libphutil

Branch

vhdl

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4745
Build 4759: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28808.Mar 4 2015, 3:37 PM

epriestley retitled this revision from to Support VHDL file extension in pygments.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7456: Syntax highlighting for VHDL files not working.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 4 2015, 3:37 PM

Actually, discussion in T3626, specifically explaining why I didn't just parse and update the whole map (it's complex, messy, and not backward compatible across Pygments versions).

chad accepted this revision.Mar 4 2015, 4:51 PM

chad added a reviewer: chad.

This revision is now accepted and ready to land.Mar 4 2015, 4:51 PM

Closed by commit rPHUeaa6ebecef8e: Support VHDL file extension in pygments (authored by epriestley, committed by epriestley). · Explain WhyMar 4 2015, 4:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

markup/

syntax/

highlighter/

PhutilPygmentsSyntaxHighlighter.php

1 line

Diff 28808

View Options

src/markup/syntax/highlighter/PhutilPygmentsSyntaxHighlighter.php

Support VHDL file extension in pygmentsClosedPublicActions