Page MenuHomePhabricator
Differential D11967

Support VHDL file extension in pygments
ClosedPublic
Actions

Authored by epriestley on Mar 4 2015, 3:37 PM.
Tags
None
Referenced Files
F14015866: D11967.diff
Mon, Nov 4, 2:04 AM
F13984087: D11967.id28808.diff
Sun, Oct 20, 10:54 AM
F13974822: D11967.id28810.diff
Fri, Oct 18, 7:31 AM
Unknown Object (File)
Sep 18 2024, 9:49 PM
Unknown Object (File)
Sep 15 2024, 10:07 AM
Unknown Object (File)
Sep 2 2024, 2:47 PM
Unknown Object (File)
Aug 31 2024, 12:21 PM
Unknown Object (File)
Aug 29 2024, 10:43 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T7456: Syntax highlighting for VHDL files not working
Commits
rPHUeaa6ebecef8e: Support VHDL file extension in pygments
Summary

Fixes T7456. See that task for some additional discussion.

Test Plan

Read carefully.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28808.Mar 4 2015, 3:37 PM
epriestley retitled this revision from to Support VHDL file extension in pygments.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7456: Syntax highlighting for VHDL files not working.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 4 2015, 3:37 PM
epriestley added a comment.Mar 4 2015, 3:52 PM

Actually, discussion in T3626, specifically explaining why I didn't just parse and update the whole map (it's complex, messy, and not backward compatible across Pygments versions).

chad accepted this revision.Mar 4 2015, 4:51 PM
chad added a reviewer: chad.
This revision is now accepted and ready to land.Mar 4 2015, 4:51 PM
Closed by commit rPHUeaa6ebecef8e: Support VHDL file extension in pygments (authored by epriestley, committed by epriestley). · Explain WhyMar 4 2015, 4:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
markup/
syntax/
highlighter/
1 line

Diff 28810

View Options

src/markup/syntax/highlighter/PhutilPygmentsSyntaxHighlighter.php

Loading...
Phabricator · Built by Phacility