Page MenuHomePhabricator
Differential D11954

Don't match parentheses as a hashtag character
ClosedPublic
Actions

Authored by epriestley on Mar 3 2015, 11:54 AM.

Details

Reviewers
btrahan
Maniphest Tasks
T6818: Don't match ")" in hashtags in Remarkup
Commits
Restricted Diffusion Commit
rPf391364bb74d: Don't match parentheses as a hashtag character
Summary

Fixes T6818.

Test Plan

Added and ran unit tests.

Diff Detail

Repository
rP Phabricator
Branch
parens
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4732
Build 4746: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28780.Mar 3 2015, 11:54 AM
epriestley retitled this revision from to Don't match parentheses as a hashtag character.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T6818: Don't match ")" in hashtags in Remarkup.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 3 2015, 11:55 AM
btrahan accepted this revision.Mar 3 2015, 3:26 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 3 2015, 3:26 PM
Closed by commit rPf391364bb74d: Don't match parentheses as a hashtag character (authored by epriestley, committed by epriestley). · Explain WhyMar 3 2015, 6:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
project/
remarkup/
2 lines
__tests__/
25 lines

Diff 28780

View Options

src/applications/project/remarkup/ProjectRemarkupRule.php

Loading...
View Options

src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php

Loading...
Phabricator · Built by Phacility