Page MenuHomePhabricator
Differential D11928

Fix an issue with collation construction on "sort" columns for old MySQL
ClosedPublic
Actions

Authored by epriestley on Mar 2 2015, 3:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 10:53 PM
Unknown Object (File)
Sat, Nov 23, 3:56 PM
Unknown Object (File)
Fri, Nov 22, 10:58 PM
Unknown Object (File)
Fri, Nov 22, 10:16 PM
Unknown Object (File)
Fri, Nov 22, 10:16 PM
Unknown Object (File)
Fri, Nov 22, 10:16 PM
Unknown Object (File)
Fri, Nov 22, 10:00 PM
Unknown Object (File)
Mon, Nov 18, 3:38 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7422: COLLATION 'utf8_general_ci' is not valid for CHARACTER SET 'binary' error
Commits
Restricted Diffusion Commit
rP184619730fb7: Fix an issue with collation construction on "sort" columns for old MySQL
Summary

Fixes T7422. We'll currently choose a "binary" charset with a "utf8_general_ci" collation on "sort" columns on older MySQL, which seems to be causing problems.

Choose "utf8" in this case instead.

(I attempted to simplify the logic, too, but that's the only actual change.)

Test Plan

Went back and forth with --disable-utf8mb4 on storage adjust, but this is version dependent so I'm not 100% sure it's the right fix.

Diff Detail

Repository
rP Phabricator
Branch
storage1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4704
Build 4718: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28734.Mar 2 2015, 3:59 PM
epriestley retitled this revision from to Fix an issue with collation construction on "sort" columns for old MySQL.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7422: COLLATION 'utf8_general_ci' is not valid for CHARACTER SET 'binary' error.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 2 2015, 3:59 PM
epriestley mentioned this in T7422: COLLATION 'utf8_general_ci' is not valid for CHARACTER SET 'binary' error.Mar 2 2015, 4:00 PM
epriestley abandoned this revision.Mar 2 2015, 4:05 PM

This is fixing the wrong thing.

epriestley reclaimed this revision.Mar 2 2015, 4:16 PM

Actually, this isn't really causing a problem, but I think it is still worth fixing.

Without it, we get extra adjust adjustments after doing a --disable-utf8mb4 upgrade, after D11929.

btrahan accepted this revision.Mar 2 2015, 5:54 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 2 2015, 5:54 PM
Closed by commit rP184619730fb7: Fix an issue with collation construction on "sort" columns for old MySQL (authored by epriestley, committed by epriestley). · Explain WhyMar 2 2015, 5:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
config/
schema/
78 lines

Diff 28734

View Options

src/applications/config/schema/PhabricatorConfigSchemaSpec.php

Loading...
Phabricator · Built by Phacility