Page MenuHomePhabricator
Differential D11929

Fix quickstart.sql for old MySQL
ClosedPublic
Actions

Authored by epriestley on Mar 2 2015, 4:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 12, 2:35 PM
Unknown Object (File)
Thu, Sep 12, 2:34 PM
Unknown Object (File)
Thu, Sep 12, 2:34 PM
Unknown Object (File)
Thu, Sep 12, 2:34 PM
Unknown Object (File)
Thu, Aug 29, 4:33 AM
Unknown Object (File)
Tue, Aug 27, 1:22 AM
Unknown Object (File)
Mon, Aug 19, 3:23 AM
Unknown Object (File)
Thu, Aug 15, 8:18 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7422: COLLATION 'utf8_general_ci' is not valid for CHARACTER SET 'binary' error
Commits
Restricted Diffusion Commit
rPa65667443b04: Fix quickstart.sql for old MySQL
Summary

Fixes T7422. After the recent fix for "sort" columns, we can end up with invalid SQL in some cases when running quickstart.

In particular, we do "COLLATE binary CHARACTER SET utf8_general_ci" (which is invalid).

Preprocess these so we get "COLLATE utf8 CHARACTER SET utf8_general_ci" (which is valid and correct).

Test Plan

Ran bin/storage upgrade -f --namespace blahblhbaba with and without --disable-utf8mb4.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
resources/
sql/
87 lines
src/
infrastructure/
storage/
management/
4 lines
workflow/
10 lines

Diff 28745

View Options

resources/sql/quickstart.sql

Loading...
View Options

src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementQuickstartWorkflow.php

Loading...
Phabricator · Built by Phacility