Differential D11924

Fix lispum generation of Pholio mocks
ClosedPublic
Actions

Authored by epriestley on Mar 2 2015, 2:49 PM.

Details

Reviewers

joshuaspence
btrahan

Maniphest Tasks

T7406: `./bin/lipsum generate` is broken for generating Pholio Mocks

Commits

Restricted Diffusion Commit
rPa9b4197f9302: Fix lispum generation of Pholio mocks

Summary

Fixes T7406. Unbreak this oldschool code.

Test Plan

GENERATING: PhabricatorPholioMockTestDataGenerator
Generated Mock: M8: Ipsum est eu enim magna do; reprehenderit.
Generated Mock: M9: Dolor est culpa esse cillum ullamco.
Generated Mock: M10: Lorem do cillum sint mollit: minim, in, aliqua esse.

Also created a mock normally, worked/looked fine.

Diff Detail

Repository

rP Phabricator

Branch

pholio1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4700
Build 4714: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28727.Mar 2 2015, 2:49 PM

epriestley retitled this revision from to Fix lispum generation of Pholio mocks.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: joshuaspence, btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 2 2015, 2:49 PM

epriestley updated this object.Mar 2 2015, 2:49 PM

epriestley added a task: T7406: `./bin/lipsum generate` is broken for generating Pholio Mocks.

btrahan accepted this revision.Mar 2 2015, 3:24 PM

btrahan edited edge metadata.

btrahan added inline comments.

src/applications/pholio/storage/PholioMock.php
44	This isnt a constant? No need to add one if it doesnt exist in this diff.

This revision is now accepted and ready to land.Mar 2 2015, 3:24 PM

Yeah, I was a little surprised too.

src/applications/pholio/storage/PholioMock.php
162–163	Not that I could dig up; see here and the next few lines. This should be constantized at some point.

Closed by commit rPa9b4197f9302: Fix lispum generation of Pholio mocks (authored by epriestley, committed by epriestley). · Explain WhyMar 2 2015, 4:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

pholio/

lipsum/

PhabricatorPholioMockTestDataGenerator.php

4 lines

storage/

PholioMock.php

1 line

Diff 28727

View Options

src/applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php