Paths

Table of Contentst

Differential D11914

Minor change to suppress linter warning
ClosedPublic
Actions

Authored by joshuaspence on Feb 28 2015, 11:12 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP48569f3629b2: Minor change to suppress linter warning

Summary

Explicitly declare the delimiter for preg_quote.

Test Plan

arc lint

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 28702.Feb 28 2015, 11:12 PM

joshuaspence retitled this revision from to Minor change to suppress linter warning.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 28 2015, 11:12 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley added inline comments.Feb 28 2015, 11:37 PM

src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php
195	This one contains an unquoted `#` literal in the regexp, so I'd expect it to not work?

(Just pushing back into your queue.)

This revision now requires changes to proceed.Mar 22 2015, 6:59 PM

Fix delimiter

epriestley accepted this revision.Apr 6 2015, 1:31 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 6 2015, 1:31 PM

Closed by commit rP48569f3629b2: Minor change to suppress linter warning (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 6 2015, 9:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

console/

controller/

DarkConsoleDataController.php

2 lines

infrastructure/

markup/

rule/

PhabricatorObjectRemarkupRule.php

8 lines

Diff 29552

View Options

src/applications/console/controller/DarkConsoleDataController.php