Page MenuHomePhabricator
Differential D11900

Move ui.custom_header to UI Config
ClosedPublic
Actions

Authored by chad on Feb 27 2015, 1:03 AM.
Tags
None
Referenced Files
F14054036: D11900.diff
Fri, Nov 15, 9:53 PM
F14043434: D11900.diff
Tue, Nov 12, 10:12 AM
F14028661: D11900.diff
Fri, Nov 8, 3:05 PM
F13995387: D11900.diff
Wed, Oct 23, 12:30 PM
F13993355: D11900.id28664.diff
Tue, Oct 22, 10:18 PM
F13992533: D11900.id28665.diff
Tue, Oct 22, 5:09 PM
F13990099: D11900.id.diff
Tue, Oct 22, 1:08 AM
F13987414: D11900.diff
Oct 21 2024, 9:20 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T4214: Allow installs to change or supplement the "Phabricator" icon
Commits
Restricted Diffusion Commit
rP2476cfba3d9e: Move ui.custom_header to UI Config
Summary

Moves the setting from Core to UI, also adds a link to the task for further instructions.

Test Plan

Load up config in sandbox, see new instructions.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 28664.Feb 27 2015, 1:03 AM
chad retitled this revision from to Move ui.custom_header to UI Config.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 27 2015, 1:03 AM
chad added inline comments.Feb 27 2015, 1:04 AM
src/applications/config/option/PhabricatorUIConfigOptions.php
95

I don't know how to correctly write this.

chad added a task: T4214: Allow installs to change or supplement the "Phabricator" icon.Feb 27 2015, 1:04 AM
epriestley edited edge metadata.Feb 27 2015, 1:05 AM

That looks correct, does it not work?

chad updated this revision to Diff 28665.Feb 27 2015, 1:12 AM
chad edited edge metadata.
  • Fix pht
chad added a comment.Feb 27 2015, 1:12 AM

I had a ) in the wrong place, it's fine now.

epriestley accepted this revision.Feb 27 2015, 1:18 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 27 2015, 1:18 AM
Closed by commit rP2476cfba3d9e: Move ui.custom_header to UI Config (authored by chad, committed by chad). · Explain WhyFeb 27 2015, 1:36 AM
This revision was automatically updated to reflect the committed changes.
• wasimsikder removed a task: T4214: Allow installs to change or supplement the "Phabricator" icon.Aug 20 2015, 9:00 AM
avivey added a task: T4214: Allow installs to change or supplement the "Phabricator" icon.Aug 20 2015, 9:43 AM

Revision Contents
Changeset List

PathSize
src/
applications/
config/
option/
23 lines
28 lines

Diff 28666

View Options

src/applications/config/option/PhabricatorCoreConfigOptions.php

Loading...
View Options

src/applications/config/option/PhabricatorUIConfigOptions.php

Loading...
Phabricator · Built by Phacility