Page MenuHomePhabricator
Differential D11895

Fix footer display when IconNav is present
ClosedPublic
Actions

Authored by chad on Feb 26 2015, 6:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 12:52 AM
Unknown Object (File)
Fri, Jan 24, 12:29 AM
Unknown Object (File)
Fri, Jan 24, 12:29 AM
Unknown Object (File)
Fri, Jan 24, 12:29 AM
Unknown Object (File)
Fri, Jan 24, 12:29 AM
Unknown Object (File)
Fri, Jan 17, 3:37 PM
Unknown Object (File)
Wed, Jan 1, 2:12 AM
Unknown Object (File)
Dec 31 2024, 5:38 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T7382: Footer looks bad on admin.phacility.com and IconNav
Commits
Restricted Diffusion Commit
rP3003b293d8ca: Fix footer display when IconNav is present
Summary

Fixes T7382, specifically we were drawing double navs, removed those from each page and added the correct CSS rule.

Test Plan

Test a number of people and profile pages with a footer set.

Diff Detail

Repository
rP Phabricator
Branch
icon-nav-footer
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4659
Build 4673: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28656.Feb 26 2015, 6:19 PM
chad retitled this revision from to Fix footer display when IconNav is present.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T7382: Footer looks bad on admin.phacility.com and IconNav.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 26 2015, 6:19 PM
epriestley accepted this revision.Feb 26 2015, 6:20 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 26 2015, 6:20 PM
Closed by commit rP3003b293d8ca: Fix footer display when IconNav is present (authored by chad, committed by chad). · Explain WhyFeb 26 2015, 6:27 PM
This revision was automatically updated to reflect the committed changes.
chad mentioned this in T7722: Footer cut on the left side on profile pages since project pane was introduced.Apr 1 2015, 3:30 PM

Revision Contents
Changeset List

Diff 28656

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleCalendarController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleFeedController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfileController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfileEditController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfilePictureController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectColumnDetailController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectColumnEditController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectEditDetailsController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectEditPictureController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectFeedController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectMembersEditController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectProfileController.php

Loading...
View Options

webroot/rsrc/css/application/base/standard-page-view.css

Loading...
Phabricator · Built by Phacility