Improve "Host" header check
ClosedPublic
Actions

Authored by epriestley on Feb 26 2015, 4:34 PM.

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rPa5426221b10c: Improve "Host" header check

Summary

See IRC. This check is somewhat misleading right now because it could arise from a mangled/broken Host header rather than a bad phabricator.base-uri configuration.

Test Plan

Faked this to trip, read all the text.

Diff Detail

Repository

rP Phabricator

Branch

hostheader

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4658
Build 4672: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28653.Feb 26 2015, 4:34 PM

epriestley retitled this revision from to Improve "Host" header check.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptFeb 26 2015, 4:34 PM

btrahan accepted this revision.Feb 26 2015, 6:09 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Feb 26 2015, 6:09 PM

Closed by commit rPa5426221b10c: Improve "Host" header check (authored by epriestley, committed by epriestley). · Explain WhyFeb 26 2015, 10:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

check/

PhabricatorBaseURISetupCheck.php

57 lines

Diff 28653

View Options

src/applications/config/check/PhabricatorBaseURISetupCheck.php

Improve "Host" header checkClosedPublicActions