Page MenuHomePhabricator
Differential D11894

Improve "Host" header check
ClosedPublic
Actions

Authored by epriestley on Feb 26 2015, 4:34 PM.
Tags
None
Referenced Files
F14734926: D11894.id28663.diff
Sat, Jan 18, 7:53 PM
Unknown Object (File)
Sat, Jan 18, 5:33 AM
Unknown Object (File)
Sat, Jan 18, 2:26 AM
Unknown Object (File)
Sun, Jan 12, 10:27 AM
Unknown Object (File)
Sat, Jan 11, 7:25 PM
Unknown Object (File)
Mon, Jan 6, 2:14 PM
Unknown Object (File)
Sun, Jan 5, 6:44 AM
Unknown Object (File)
Thu, Dec 26, 2:19 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rPa5426221b10c: Improve "Host" header check
Summary

See IRC. This check is somewhat misleading right now because it could arise from a mangled/broken Host header rather than a bad phabricator.base-uri configuration.

Test Plan

Faked this to trip, read all the text.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28653.Feb 26 2015, 4:34 PM
epriestley retitled this revision from to Improve "Host" header check.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
Herald added a subscriber: epriestley. · View Herald TranscriptFeb 26 2015, 4:34 PM
btrahan accepted this revision.Feb 26 2015, 6:09 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 26 2015, 6:09 PM
Closed by commit rPa5426221b10c: Improve "Host" header check (authored by epriestley, committed by epriestley). · Explain WhyFeb 26 2015, 10:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
config/
check/
57 lines

Diff 28663

View Options

src/applications/config/check/PhabricatorBaseURISetupCheck.php

Loading...
Phabricator · Built by Phacility