Use disabled style when viewing flags if the underlying object is closed
ClosedPublic
Actions

Authored by epriestley on Feb 25 2015, 7:48 PM.

Tags

None

Referenced Files

	F15435869: D11885.diff
	Tue, Mar 25, 10:37 AM

	F15398204: D11885.id.diff
	Sun, Mar 16, 11:47 PM

	F15387974: D11885.id28635.diff
	Sat, Mar 15, 3:09 AM

	F15387074: D11885.id28634.diff
	Sat, Mar 15, 1:47 AM

	F15385839: D11885.diff
	Fri, Mar 14, 11:31 PM

	F15382753: D11885.diff
	Fri, Mar 14, 2:16 PM

	Unknown Object (File)
	Mon, Mar 3, 8:19 AM

	Unknown Object (File)
	Sun, Mar 2, 1:58 PM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan
chad

Commits

Restricted Diffusion Commit
rP33a06c97d35e: Use disabled style when viewing flags if the underlying object is closed

Summary

See IRC. This regressed at some point, probably when we fixed these rendering links-inside-links.

Test Plan

Viewed a flagged, closed task.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28634.Feb 25 2015, 7:48 PM

epriestley retitled this revision from to Use disabled style when viewing flags if the underlying object is closed.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, chad.

Herald added a subscriber: epriestley. · View Herald TranscriptFeb 25 2015, 7:48 PM

chad accepted this revision.Feb 25 2015, 7:49 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 25 2015, 7:49 PM

Closed by commit rP33a06c97d35e: Use disabled style when viewing flags if the underlying object is closed (authored by epriestley, committed by epriestley). · Explain WhyFeb 25 2015, 7:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

flag/

query/

PhabricatorFlagSearchEngine.php

5 lines

Diff 28635

View Options

src/applications/flag/query/PhabricatorFlagSearchEngine.php

Use disabled style when viewing flags if the underlying object is closedClosedPublicActions