Page MenuHomePhabricator

Ensure spot instances in AWS are closed properly in Drydock
AbandonedPublic

Authored by hach-que on Feb 24 2015, 3:47 AM.
Tags
None
Referenced Files
F14313698: D11875.id.diff
Wed, Dec 18, 4:30 AM
Unknown Object (File)
Sun, Dec 15, 9:50 PM
Unknown Object (File)
Fri, Dec 13, 11:54 AM
Unknown Object (File)
Thu, Dec 12, 5:20 AM
Unknown Object (File)
Sun, Dec 1, 10:18 AM
Unknown Object (File)
Thu, Nov 28, 8:27 AM
Unknown Object (File)
Tue, Nov 26, 9:06 PM
Unknown Object (File)
Fri, Nov 22, 6:15 PM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T2015: Implement Drydock
Summary

Ref T2015. If you attempt to close a "Pending Allocation" resource in Drydock for an EC2 resource, and that resource was a spot request, currently you are unable to close the resource because the TerminateInstance call fails (because there is no instance).

Instead, only call TerminateInstance if there is an instance ID, and use CancelSpotInstanceRequests if a spot request ID is present. Closing pending allocation resources should only be done if the daemons were interrupted during allocation, and the resources need to be manually cleaned up or closed.

Test Plan

Not tested yet...

Diff Detail

Repository
rP Phabricator
Branch
drydock-spot-request-cleanup
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4634
Build 4648: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que retitled this revision from to Ensure spot instances in AWS are closed properly in Drydock.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
epriestley added a reviewer: epriestley.

Premature

This revision now requires changes to proceed.Aug 8 2015, 6:51 PM