Page MenuHomePhabricator

Allow modern `phd stop` to stop old daemons cleanly
ClosedPublic

Authored by epriestley on Feb 24 2015, 2:58 AM.
Tags
None
Referenced Files
F14004398: D11873.diff
Sat, Oct 26, 7:57 PM
F13998790: D11873.diff
Thu, Oct 24, 11:10 AM
F13996699: D11873.id28595.diff
Wed, Oct 23, 11:17 PM
F13980714: D11873.diff
Sat, Oct 19, 12:17 PM
F13975658: D11873.id28595.diff
Fri, Oct 18, 11:06 AM
F13966533: D11873.id28595.diff
Wed, Oct 16, 8:24 AM
Unknown Object (File)
Oct 11 2024, 4:58 AM
Unknown Object (File)
Oct 11 2024, 4:34 AM
Subscribers

Details

Summary

Ref T7352. Make sure modern phd stop can still read the old PID file format and stop the daemons, at least for now.

Without this, stop still detects them and tells you to stop --force, which works, but this makes things a good deal cleaner.

Test Plan

Ran phd stop from master, then phd stop from this revision. Saw old daemons stop cleanly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow modern `phd stop` to stop old daemons cleanly.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 24 2015, 4:58 PM
This revision was automatically updated to reflect the committed changes.