Allow modern `phd stop` to stop old daemons cleanly
ClosedPublic
Actions

Authored by epriestley on Feb 24 2015, 2:58 AM.

Details

Reviewers

btrahan

Maniphest Tasks

T7352: Improve daemon scalability in the cluster

Commits

Restricted Diffusion Commit
rP38636a39cf2d: Allow modern `phd stop` to stop old daemons cleanly

Summary

Ref T7352. Make sure modern phd stop can still read the old PID file format and stop the daemons, at least for now.

Without this, stop still detects them and tells you to stop --force, which works, but this makes things a good deal cleaner.

Test Plan

Ran phd stop from master, then phd stop from this revision. Saw old daemons stop cleanly.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28595.Feb 24 2015, 2:58 AM

epriestley retitled this revision from to Allow modern `phd stop` to stop old daemons cleanly.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7352: Improve daemon scalability in the cluster.

Herald added a subscriber: epriestley. · View Herald TranscriptFeb 24 2015, 2:58 AM

btrahan accepted this revision.Feb 24 2015, 4:58 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Feb 24 2015, 4:58 PM

Closed by commit rP38636a39cf2d: Allow modern `phd stop` to stop old daemons cleanly (authored by epriestley, committed by epriestley). · Explain WhyFeb 24 2015, 10:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

daemon/

control/

PhabricatorDaemonReference.php

14 lines

Diff 28622

View Options

src/infrastructure/daemon/control/PhabricatorDaemonReference.php

Allow modern `phd stop` to stop old daemons cleanlyClosedPublicActions