Page MenuHomePhabricator
Differential D11873

Allow modern `phd stop` to stop old daemons cleanly
ClosedPublic
Actions

Authored by epriestley on Feb 24 2015, 2:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 31, 4:09 PM
Unknown Object (File)
Sun, Aug 25, 1:29 AM
Unknown Object (File)
Sat, Aug 24, 6:39 PM
Unknown Object (File)
Sat, Aug 17, 1:58 PM
Unknown Object (File)
Aug 7 2024, 12:19 PM
Unknown Object (File)
Aug 6 2024, 7:10 PM
Unknown Object (File)
Aug 6 2024, 6:14 AM
Unknown Object (File)
Jul 24 2024, 10:15 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7352: Improve daemon scalability in the cluster
Commits
Restricted Diffusion Commit
rP38636a39cf2d: Allow modern `phd stop` to stop old daemons cleanly
Summary

Ref T7352. Make sure modern phd stop can still read the old PID file format and stop the daemons, at least for now.

Without this, stop still detects them and tells you to stop --force, which works, but this makes things a good deal cleaner.

Test Plan

Ran phd stop from master, then phd stop from this revision. Saw old daemons stop cleanly.

Diff Detail

Repository
rP Phabricator
Branch
daemon11
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4632
Build 4646: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28595.Feb 24 2015, 2:58 AM
epriestley retitled this revision from to Allow modern `phd stop` to stop old daemons cleanly.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7352: Improve daemon scalability in the cluster.
Herald added a subscriber: epriestley. · View Herald TranscriptFeb 24 2015, 2:58 AM
btrahan accepted this revision.Feb 24 2015, 4:58 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 24 2015, 4:58 PM
Closed by commit rP38636a39cf2d: Allow modern `phd stop` to stop old daemons cleanly (authored by epriestley, committed by epriestley). · Explain WhyFeb 24 2015, 10:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
daemon/
control/
14 lines

Diff 28595

View Options

src/infrastructure/daemon/control/PhabricatorDaemonReference.php

Loading...
Phabricator · Built by Phacility