Page MenuHomePhabricator
Differential D11848

Make Project Mobile menu more resilient
ClosedPublic
Actions

Authored by chad on Feb 21 2015, 3:10 PM.
Tags
None
Referenced Files
F14371546: D11848.diff
Fri, Dec 20, 7:05 PM
Unknown Object (File)
Wed, Dec 18, 5:45 AM
Unknown Object (File)
Wed, Dec 11, 12:42 AM
Unknown Object (File)
Mon, Dec 9, 9:37 AM
Unknown Object (File)
Mon, Dec 9, 9:37 AM
Unknown Object (File)
Sat, Dec 7, 6:00 PM
Unknown Object (File)
Sat, Dec 7, 8:34 AM
Unknown Object (File)
Tue, Dec 3, 10:47 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T7289: Projects sidebar does not appear on mobile
Commits
Restricted Diffusion Commit
rPb070ed50197f: Make Project Mobile menu more resilient
Summary

This sets $project at the controller level so it's available to building the icon nav and mobile menu, instead of guessing the $id. Fixes T7289

Test Plan

Test a project and its mobile menu when it does and does not have a workboard initialized. Also tested coming in via a slug and an id.

Diff Detail

Repository
rP Phabricator
Branch
projects-mobile-menu
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4618
Build 4632: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28552.Feb 21 2015, 3:10 PM
chad retitled this revision from to Make Project Mobile menu more resilient.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T7289: Projects sidebar does not appear on mobile.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 21 2015, 3:10 PM
chad added a reviewer: btrahan.Feb 23 2015, 5:27 PM
btrahan accepted this revision.Feb 23 2015, 5:33 PM
btrahan edited edge metadata.

Silly (anal?) style stuff in line.

src/applications/project/controller/PhabricatorProjectController.php
21

getProject()

29–30

just if ($project)

53

can just lose line 53

This revision is now accepted and ready to land.Feb 23 2015, 5:33 PM
chad updated this revision to Diff 28579.Feb 23 2015, 7:27 PM
chad edited edge metadata.
  • Update per comments, retest
Closed by commit rPb070ed50197f: Make Project Mobile menu more resilient (authored by chad, committed by chad). · Explain WhyFeb 23 2015, 7:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
project/
controller/
10 lines
21 lines

Diff 28579

View Options

src/applications/project/controller/PhabricatorProjectBoardController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectController.php

Loading...
Phabricator · Built by Phacility