HomePhabricator

Add SUCCESS state and buttons to PHUIErrorView

Tags
None
Referenced Files
F311943: pasted_file
Feb 23 2015, 7:03 PM
Subscribers
None

Description

Add SUCCESS state and buttons to PHUIErrorView

Summary: I'm looking at beefing up PHUIErrorView for additional use cases as I remove some older AphrontViews. This will likely morph into PHUIInfoView and be a more lightweight version of PHUIObjectBox.

Test Plan:
UIExamples, mobile and desktop layouts. Have actual use cases coming in next diffs (may tweak design more then)

pasted_file (296×525 px, 44 KB)

Reviewers: epriestley, btrahan

Reviewed By: btrahan

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11849

Details

Provenance
chadAuthored on
chadPushed on Feb 23 2015, 7:03 PM
Reviewer
btrahan
Differential Revision
D11849: Add SUCCESS state and buttons to PHUIErrorView
Parents
rP15824bd51676: Fix People mobile menu URLs
Branches
Unknown
Tags
Unknown

Event Timeline

We may not use SUCCESS much in practice. I think it's useful in labeling actual success (like a passed build, or launched instance) vs. an everyday expected success (saved form) where NOTICE is still likely correct. It may turn out useless in actual practice though.