Page MenuHomePhabricator

Make Project Mobile menu more resilient
ClosedPublic

Authored by chad on Feb 21 2015, 3:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 27 2024, 5:13 PM
Unknown Object (File)
Jan 26 2024, 8:19 PM
Unknown Object (File)
Jan 22 2024, 11:07 PM
Unknown Object (File)
Jan 15 2024, 5:27 AM
Unknown Object (File)
Jan 15 2024, 5:19 AM
Unknown Object (File)
Jan 15 2024, 5:18 AM
Unknown Object (File)
Jan 15 2024, 5:18 AM
Unknown Object (File)
Jan 9 2024, 11:41 AM
Subscribers

Details

Summary

This sets $project at the controller level so it's available to building the icon nav and mobile menu, instead of guessing the $id. Fixes T7289

Test Plan

Test a project and its mobile menu when it does and does not have a workboard initialized. Also tested coming in via a slug and an id.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Make Project Mobile menu more resilient.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
btrahan edited edge metadata.

Silly (anal?) style stuff in line.

src/applications/project/controller/PhabricatorProjectController.php
21

getProject()

29–30

just if ($project)

53

can just lose line 53

This revision is now accepted and ready to land.Feb 23 2015, 5:33 PM
chad edited edge metadata.
  • Update per comments, retest
This revision was automatically updated to reflect the committed changes.