Page MenuHomePhabricator

Implement more consistent publishing rules for repositories
ClosedPublic

Authored by epriestley on Feb 19 2015, 5:18 PM.
Tags
None
Referenced Files
F18048419: D11826.diff
Sun, Aug 3, 1:33 PM
F17953025: D11826.id28500.diff
Fri, Aug 1, 2:42 AM
F17941352: D11826.id.diff
Thu, Jul 31, 5:20 AM
F17937266: D11826.id28509.diff
Thu, Jul 31, 1:00 AM
F17919949: D11826.diff
Wed, Jul 30, 3:07 AM
F17818887: D11826.id28500.diff
Sat, Jul 26, 12:45 AM
Unknown Object (File)
May 9 2025, 6:14 PM
Unknown Object (File)
May 8 2025, 11:23 AM
Subscribers

Details

Summary

Ref T7298. We are currently inconsistent about when we publish feed, email, notifications, audits and Herald rules.

Specifically, there are two settings which impact these things:

  • The "importing" flag, which is set when we're importing old commits.
  • The "herald-disabled" flag, which was expanded in scope some time ago and now actually means "disable publishing".

Various parts of the pipeline were checking only one of these flags. Instead, all of them should check both.

(For example, we should never email users about importing repositories, nor trigger audits on them.)

Test Plan

See next revision.

Diff Detail

Repository
rP Phabricator
Branch
rpublish
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/audit/editor/PhabricatorAuditEditor.php:527XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 4568
Build 4582: [Placeholder Plan] Wait for 30 Seconds