Differential D11812

Projects - add translation for watcher strings
ClosedPublic
Actions

Authored by btrahan on Feb 18 2015, 11:27 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T7319: '1 watcher(s)' as well as 'a member' in project edit logs

Commits

Restricted Diffusion Commit
rP7ef5c5293490: Projects - add translation for watcher strings

Summary

Fixes T7319. ...except I can't get this working in my sandbox? Changes to the translation file don't seem to show up. TEST PLAN IS A LIE

Test Plan

became a watcher, un became a watcher - saw sensical translated strings

Diff Detail

Repository

rP Phabricator

Branch

T7319

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4551
Build 4565: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 28472.Feb 18 2015, 11:27 PM

btrahan added a task: T7319: '1 watcher(s)' as well as 'a member' in project edit logs.

btrahan retitled this revision from to Projects - add translation for watcher strings.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 18 2015, 11:27 PM

epriestley accepted this revision.Feb 18 2015, 11:27 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 18 2015, 11:27 PM

Closed by commit rP7ef5c5293490: Projects - add translation for watcher strings (authored by btrahan, committed by btrahan). · Explain WhyFeb 18 2015, 11:33 PM

This revision was automatically updated to reflect the committed changes.

btrahan mentioned this in D11813: Projects - fix translation strings in watcher edge class.Feb 18 2015, 11:38 PM

btrahan mentioned this in rPa77127ab63bf: Projects - fix translation strings in watcher edge class.Feb 18 2015, 11:45 PM

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

internationalization/

translation/

PhabricatorUSEnglishTranslation.php

17 lines

Diff 28472

View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Projects - add translation for watcher stringsClosedPublicActions