Page MenuHomePhabricator

Projects - fix translation strings in watcher edge class
ClosedPublic

Authored by btrahan on Feb 18 2015, 11:38 PM.
Tags
None
Referenced Files
F19479312: D11813.diff
Wed, Jan 7, 9:47 PM
F19107860: D11813.diff
Dec 8 2025, 12:26 PM
F19016249: D11813.id.diff
Nov 23 2025, 3:20 AM
F19015080: D11813.diff
Nov 22 2025, 10:39 PM
F18855646: D11813.id28477.diff
Nov 1 2025, 6:04 AM
F18832292: D11813.diff
Oct 25 2025, 9:13 PM
F18812221: D11813.id28474.diff
Oct 20 2025, 7:48 AM
F18812205: D11813.id28477.diff
Oct 20 2025, 7:43 AM
Subscribers

Details

Summary

Fixes T7319. These need a "%s" for the count where they had a "%d"

Test Plan

plan in D11812 is no longer a lie! (watcher added / removed strings render correctly)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Projects - fix translation strings in edge class.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
btrahan retitled this revision from Projects - fix translation strings in edge class to Projects - fix translation strings in watcher edge class.Feb 18 2015, 11:38 PM

The %s is correct, so maybe the other ones should flip?

This is kind of unintuitive, but basically the rule is "%s" to render as "2,345,678" (i.e., with commas and periods) and "%d" to render as "2345678". So "You see %s things(s)", but "Task ID %d".

epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 18 2015, 11:44 PM
btrahan edited edge metadata.
This revision was automatically updated to reflect the committed changes.