Fixes T7294. This lets legalpad store other documents that don't need signatures but conceptually belong in legalpad.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T7294: Add a "Who should sign: no one" option to Legalpad
- Commits
- Restricted Diffusion Commit
rP733a9c40eead: Legalpad - add "no one" signature type
made a document with signature type "no one" and it saved. viewed the document and noted no signing UI was present.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T7294
- Lint
Lint Passed Severity Location Code Message Advice src/applications/legalpad/controller/LegalpadDocumentSignController.php:38 XHP16 TODO Comment - Unit
No Test Coverage - Build Status
Buildable 4519 Build 4533: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| src/applications/legalpad/storage/LegalpadDocument.php | ||
|---|---|---|
| 136 | Maybe put this last in the list, since it'll default on new documents I think but "individuals" is probably the best / most common default? | |
Comment Actions
move "no one" to last in dropdown since its least common. (initNewDocument handled the doc type default already, but its nice to put this rare option in the back)