Differential D11788

Legalpad - add "no one" signature type
ClosedPublic
Actions

Authored by btrahan on Feb 17 2015, 7:39 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 15, 8:44 PM

	Unknown Object (File)
	Tue, Apr 9, 8:02 AM

	Unknown Object (File)
	Mon, Apr 8, 1:05 PM

	Unknown Object (File)
	Mon, Apr 8, 8:49 AM

	Unknown Object (File)
	Mon, Apr 8, 8:49 AM

	Unknown Object (File)
	Mon, Apr 8, 8:48 AM

	Unknown Object (File)
	Mon, Apr 8, 8:38 AM

	Unknown Object (File)
	Mon, Apr 8, 8:23 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T7294: Add a "Who should sign: no one" option to Legalpad

Commits

Restricted Diffusion Commit
rP733a9c40eead: Legalpad - add "no one" signature type

Summary

Fixes T7294. This lets legalpad store other documents that don't need signatures but conceptually belong in legalpad.

Test Plan

made a document with signature type "no one" and it saved. viewed the document and noted no signing UI was present.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 28413.Feb 17 2015, 7:39 PM

btrahan added a task: T7294: Add a "Who should sign: no one" option to Legalpad.

btrahan retitled this revision from to Legalpad - add "no one" signature type.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 17 2015, 7:39 PM

epriestley accepted this revision.Feb 17 2015, 7:42 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/legalpad/storage/LegalpadDocument.php
136	Maybe put this last in the list, since it'll default on new documents I think but "individuals" is probably the best / most common default?

This revision is now accepted and ready to land.Feb 17 2015, 7:42 PM

move "no one" to last in dropdown since its least common. (initNewDocument handled the doc type default already, but its nice to put this rare option in the back)

Closed by commit rP733a9c40eead: Legalpad - add "no one" signature type (authored by btrahan, committed by btrahan). · Explain WhyFeb 17 2015, 7:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

legalpad/

controller/

LegalpadDocumentEditController.php

12 lines

LegalpadDocumentSignController.php

202 lines

storage/

LegalpadDocument.php

5 lines

Diff 28415

src/applications/legalpad/controller/LegalpadDocumentEditController.php

Loading...

src/applications/legalpad/controller/LegalpadDocumentSignController.php

Loading...

src/applications/legalpad/storage/LegalpadDocument.php

Loading...