Page MenuHomePhabricator

Lock all reply-handler options in the upstream, plus cookie prefix
ClosedPublic

Authored by epriestley on Feb 13 2015, 3:53 PM.
Tags
None
Referenced Files
F13224643: D11764.diff
Sun, May 19, 9:48 AM
Unknown Object (File)
Sat, Apr 27, 3:35 PM
Unknown Object (File)
Apr 16 2024, 10:54 AM
Unknown Object (File)
Apr 7 2024, 3:23 AM
Unknown Object (File)
Apr 3 2024, 5:43 AM
Unknown Object (File)
Apr 1 2024, 1:23 PM
Unknown Object (File)
Feb 7 2024, 8:52 AM
Unknown Object (File)
Feb 7 2024, 8:52 AM
Subscribers

Details

Summary

Ref T7185. These settings shouldn't be unlocked anywhere. Specifically:

  • reply-handler: These are on the way out.
  • reply-handler-domain: Also hopefully on the way out; locked because a compromised administrator account can redirect replies.
  • phabricator.cookie-prefix: Not dangerous per se, but an admin could have a hard time fixing this if they changed it by accident since their session would become invalid immediately.
Test Plan

Browsed Config.

Diff Detail

Repository
rP Phabricator
Branch
config2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4493
Build 4507: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Lock all reply-handler options in the upstream, plus cookie prefix.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 13 2015, 5:47 PM
This revision was automatically updated to reflect the committed changes.