HomePhabricator

Upgrade "masked" config to "hidden"

Description

Upgrade "masked" config to "hidden"

Summary:
Ref T7185. We currently have "locked", "masked", and "hidden" config.

However, "masked" does not really do anything. It was intended to mask values in DarkConsole, but Config got built out instead and "hidden" is strictly better in modern usage and protects against compromised administrator accounts. "hidden" implies "locked", so it's now strictly more powerful than just locked.

Remove "masked" and upgrade all "masked" config to "hidden". In particular, this hides some API keys and secret keys much more aggressively in Config, which is desirable.

Test Plan: Browsed things like S3 API keys in config and could no longer see them.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7185

Differential Revision: https://secure.phabricator.com/D11763

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Feb 13 2015, 6:59 PM
Reviewer
btrahan
Differential Revision
D11763: Upgrade "masked" config to "hidden"
Parents
rPf74fa4963687: Clean up a text string
Branches
Unknown
Tags
Unknown
Tasks
T7185: Review all configuration and lock anything that has paths or magic in it