Page MenuHomePhabricator

Upgrade "masked" config to "hidden"
ClosedPublic

Authored by epriestley on Feb 13 2015, 3:48 PM.
Tags
None
Referenced Files
F15665826: D11763.diff
Sun, May 25, 6:31 AM
Unknown Object (File)
Mon, May 19, 4:32 AM
Unknown Object (File)
Sun, May 18, 5:54 PM
Unknown Object (File)
Apr 25 2025, 6:22 AM
Unknown Object (File)
Apr 15 2025, 5:10 AM
Unknown Object (File)
Apr 10 2025, 5:37 AM
Unknown Object (File)
Mar 21 2025, 7:22 AM
Unknown Object (File)
Mar 21 2025, 12:47 AM
Subscribers

Details

Summary

Ref T7185. We currently have "locked", "masked", and "hidden" config.

However, "masked" does not really do anything. It was intended to mask values in DarkConsole, but Config got built out instead and "hidden" is strictly better in modern usage and protects against compromised administrator accounts. "hidden" implies "locked", so it's now strictly more powerful than just locked.

Remove "masked" and upgrade all "masked" config to "hidden". In particular, this hides some API keys and secret keys much more aggressively in Config, which is desirable.

Test Plan

Browsed things like S3 API keys in config and could no longer see them.

Diff Detail

Repository
rP Phabricator
Branch
config1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4492
Build 4506: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Upgrade "masked" config to "hidden".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 13 2015, 5:47 PM
This revision was automatically updated to reflect the committed changes.