Differential D11753

Allow Home and Dashboards to be uninstalled
ClosedPublic
Actions

Authored by epriestley on Feb 11 2015, 10:57 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T7143: Improve initial UX for new users on admin.phacility.com

Commits

Restricted Diffusion Commit
rP30b201bade40: Allow Home and Dashboards to be uninstalled

Summary

Ref T7143. This is the simplest fix for adding a new route for Home, at the cost of possibly letting users break instances. However:

It's kind of hard to get to the option to uninstall Home anyway.
It's hard to imagine anyone will really uninstall Home by accident, right? Right?
Put a really scary warning on the action just in case.

Dashboards was only required because Home was required, I think, so just drop that too.

Test Plan

Uninstalled home.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28333.Feb 11 2015, 10:57 PM

epriestley retitled this revision from to Allow Home and Dashboards to be uninstalled.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7143: Improve initial UX for new users on admin.phacility.com.

Herald added a subscriber: epriestley. · View Herald TranscriptFeb 11 2015, 10:57 PM

Even if you do this, you can still reinstall the application, you just need to get back to Applications somehow (e.g., back button or search or typing in the URL).

If users do manage to do this by accident, we could special case the "/" route if no controller matches it and print out some kind of "go reinstall Home" thing, but that was a bit of a mess and didn't feel very general so I figured we could wait until someone manages to do this.

btrahan accepted this revision.Feb 11 2015, 11:20 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Feb 11 2015, 11:20 PM