Fixes T7182.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T7182: Allow books to be destroyed
- Commits
- Restricted Diffusion Commit
rP5a20daedc71a: Allow diviner books to be permanently destroyed
Deleted a book with ./bin/remove destroy
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4460 Build 4474: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
One inline.
| src/applications/diviner/storage/DivinerLiveBook.php | ||
|---|---|---|
| 104 | I don't think destroyObjectPermanently() should print to the console. You can use --trace to monitor status, and it automatically keeps a log of deleted objects (bin/remove log). If you want a progress bar specifically, we could add a destroyObjects(...) and let the Engine build the bar when run via a console? I'm generally onboard with bin/remove destroy being more verbose, but I think the Engine should be responsible, not the destroyObject...() implementations. | |
| src/applications/diviner/storage/DivinerLiveBook.php | ||
|---|---|---|
| 104 | Oh yep, I had intended to remove this. Basically, destroying a book took a lot longer than I had expected (maybe 5 minutes). | |