Page MenuHomePhabricator

Allow diviner books to be permanently destroyed
ClosedPublic

Authored by joshuaspence on Feb 11 2015, 1:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 2, 9:41 PM
Unknown Object (File)
Thu, Feb 2, 9:41 PM
Unknown Object (File)
Thu, Feb 2, 9:41 PM
Unknown Object (File)
Thu, Jan 12, 9:56 PM
Unknown Object (File)
Jan 3 2023, 11:29 PM
Unknown Object (File)
Jan 3 2023, 3:27 AM
Unknown Object (File)
Dec 26 2022, 7:29 PM
Unknown Object (File)
Dec 25 2022, 9:59 AM
Subscribers

Details

Summary

Fixes T7182.

Test Plan

Deleted a book with ./bin/remove destroy

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Allow diviner books to be permanently destroyed.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

One inline.

src/applications/diviner/storage/DivinerLiveBook.php
104

I don't think destroyObjectPermanently() should print to the console.

You can use --trace to monitor status, and it automatically keeps a log of deleted objects (bin/remove log).

If you want a progress bar specifically, we could add a destroyObjects(...) and let the Engine build the bar when run via a console? I'm generally onboard with bin/remove destroy being more verbose, but I think the Engine should be responsible, not the destroyObject...() implementations.

This revision is now accepted and ready to land.Feb 11 2015, 1:47 PM
src/applications/diviner/storage/DivinerLiveBook.php
104

Oh yep, I had intended to remove this. Basically, destroying a book took a lot longer than I had expected (maybe 5 minutes).

joshuaspence edited edge metadata.

Remove console logging

This revision was automatically updated to reflect the committed changes.