Page MenuHomePhabricator
Differential D11729

Create log directory if it does not exist
ClosedPublic
Actions

Authored by joshuaspence on Feb 10 2015, 7:33 AM.
Tags
None
Referenced Files
F13261307: D11729.diff
Mon, May 27, 12:53 AM
F13251585: D11729.id.diff
Sat, May 25, 12:13 AM
F13251181: D11729.id28267.diff
Fri, May 24, 8:54 PM
F13248640: D11729.id28265.diff
Fri, May 24, 3:38 AM
F13243887: D11729.diff
Thu, May 23, 4:19 AM
F13239049: D11729.id.diff
Tue, May 21, 11:43 PM
F13238943: D11729.diff
Tue, May 21, 10:49 PM
F13234929: D11729.id28267.diff
Tue, May 21, 3:57 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUe0e4e83511d6: Create log directory if it does not exist
Summary

Create log directory if it does not exist. In particular, I want to check log.access.path if it does not exist.

Test Plan

Saw the log directory created.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4419
Build 4433: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 28244.Feb 10 2015, 7:33 AM
joshuaspence retitled this revision from to Create log directory if it does not exist.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 10 2015, 7:33 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this object.Feb 10 2015, 12:33 PM
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence edited edge metadata.
epriestley accepted this revision.Feb 10 2015, 2:21 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/filesystem/PhutilDeferredLog.php
71

Maybe consider passing ..., 0755, true to try to create it recursively.

This revision is now accepted and ready to land.Feb 10 2015, 2:21 PM
joshuaspence added a comment.Feb 10 2015, 7:55 PM

Do you think that maybe the directory creation should happen in write()?

joshuaspence updated this revision to Diff 28265.Feb 10 2015, 7:55 PM
joshuaspence edited edge metadata.

Recursively create directory

epriestley added a comment.Feb 10 2015, 8:00 PM

Since setFile() exists and could change the file location, probably.

joshuaspence updated this revision to Diff 28267.Feb 10 2015, 8:03 PM

Move to write()

Closed by commit rPHUe0e4e83511d6: Create log directory if it does not exist (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 10 2015, 8:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
filesystem/
5 lines

Diff 28244

View Options

src/filesystem/PhutilDeferredLog.php

Loading...
Phabricator · Built by Phacility