Reject objects with invalid policies instead of fataling
ClosedPublic
Actions

Authored by epriestley on Feb 10 2015, 1:52 AM.

Tags

None

Referenced Files

	F14008424: D11727.id.diff
	Tue, Oct 29, 9:10 PM

	F14000117: D11727.diff
	Thu, Oct 24, 7:20 PM

	F13997817: D11727.diff
	Thu, Oct 24, 6:21 AM

	F13982950: D11727.id28260.diff
	Oct 20 2024, 3:08 AM

	Unknown Object (File)
	Oct 7 2024, 1:10 AM

	Unknown Object (File)
	Oct 7 2024, 1:10 AM

	Unknown Object (File)
	Oct 7 2024, 1:10 AM

	Unknown Object (File)
	Oct 7 2024, 1:01 AM

View All Files

Subscribers

epriestley

Details

Reviewers

joshuaspence

Commits

Restricted Diffusion Commit
rP767397ee14ec: Reject objects with invalid policies instead of fataling

Summary

This is correct, but the root cause of the issue isn't very clear to me.

Test Plan

Poked around various pages which filter objects.

Diff Detail

Repository

rP Phabricator

Branch

deadpolicy

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4416
Build 4429: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28240.Feb 10 2015, 1:52 AM

epriestley retitled this revision from to Reject objects with invalid policies instead of fataling.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: joshuaspence.

Herald added a subscriber: epriestley. · View Herald TranscriptFeb 10 2015, 1:52 AM

Yeah, this seems to have fixed our issue.

This revision is now accepted and ready to land.Feb 10 2015, 2:53 AM

Closed by commit rP767397ee14ec: Reject objects with invalid policies instead of fataling (authored by epriestley, committed by epriestley). · Explain WhyFeb 10 2015, 2:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

policy/

filter/

PhabricatorPolicyFilter.php

6 lines

Diff 28240

View Options

src/applications/policy/filter/PhabricatorPolicyFilter.php

Reject objects with invalid policies instead of fatalingClosedPublicActions