Page MenuHomePhabricator
Differential D11715

Fix a TODO
ClosedPublic
Actions

Authored by joshuaspence on Feb 8 2015, 8:23 PM.
Tags
None
Referenced Files
F14369198: D11715.id28190.diff
Fri, Dec 20, 4:36 PM
Unknown Object (File)
Fri, Dec 13, 11:12 PM
Unknown Object (File)
Mon, Dec 9, 11:11 PM
Unknown Object (File)
Sun, Dec 8, 11:02 PM
Unknown Object (File)
Thu, Dec 5, 2:04 AM
Unknown Object (File)
Sun, Dec 1, 6:29 AM
Unknown Object (File)
Wed, Nov 27, 2:37 AM
Unknown Object (File)
Sat, Nov 23, 2:57 PM
View All Files
Subscribers
epriestley

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPc66954af262f: Fix a TODO
Summary

Rename DifferentialChangesetParser::WHITESPACE_IGNORE_ALL to DifferentialChangesetParser::WHITESPACE_IGNORE_MOST.

Test Plan

Browsed a diff with a few different settings for "Whitespace changes".

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4388
Build 4401: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 28190.Feb 8 2015, 8:23 PM
joshuaspence retitled this revision from to Sort of fix a TODO.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 8 2015, 8:23 PM
Herald added a subscriber: epriestley. · View Herald Transcript
epriestley accepted this revision.Feb 9 2015, 2:06 PM
epriestley added a reviewer: epriestley.
This revision is now accepted and ready to land.Feb 9 2015, 2:06 PM
joshuaspence retitled this revision from Sort of fix a TODO to Fix a TODO.Feb 10 2015, 7:37 AM
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence edited edge metadata.
Closed by commit rPc66954af262f: Fix a TODO (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 10 2015, 7:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
2 lines
parser/
11 lines
view/
2 lines

Diff 28190

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/parser/DifferentialChangesetParser.php

Loading...
View Options

src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php

Loading...
Phabricator · Built by Phacility