Page MenuHomePhabricator

Policy - make sure "quick create" menu doesn't show up if you have nothing you can quick create
ClosedPublic

Authored by btrahan on Feb 4 2015, 10:51 PM.
Tags
None
Referenced Files
F14057917: D11684.diff
Sun, Nov 17, 8:01 AM
F14012209: D11684.diff
Fri, Nov 1, 8:39 AM
F13988754: D11684.id28120.diff
Mon, Oct 21, 3:46 PM
Unknown Object (File)
Oct 7 2024, 5:09 PM
Unknown Object (File)
Sep 29 2024, 1:15 AM
Unknown Object (File)
Sep 21 2024, 10:07 PM
Unknown Object (File)
Sep 21 2024, 10:07 PM
Unknown Object (File)
Sep 21 2024, 10:06 PM
Subscribers

Details

Summary

Fixes T7117. The slightly icky part is we just build the menu items up 2x because there's no way to tell you wont be able to make a menu item unless you try to make them all and come up with nada.

Test Plan

created a user and denied them access to every application in the quick create menu. observed the "+" icon disappearing from the nav, correctly. used a different, unrestricted user and the menu showed up and worked

Diff Detail

Repository
rP Phabricator
Branch
T7117
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4338
Build 4351: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Policy - make sure "quick create" menu doesn't show up if you have nothing you can quick create.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
chad added a reviewer: chad.
This revision is now accepted and ready to land.Feb 4 2015, 10:52 PM
This revision was automatically updated to reflect the committed changes.