Some commands (like get-config) do not require a working copy at all. Recent changes prevented these commands from running outside a VCS working copy.
Let null mean "no working copy".
See also https://github.com/phacility/phabricator/issues/800.
Details
Details
- Ran arc get-config from outside a working copy.
- Ran arc list from outside a working copy, got an error.
- Ran arc commit in a Git working copy, got an error.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- nowc
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4293 Build 4306: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| src/workflow/ArcanistWorkflow.php | ||
|---|---|---|
| 1219 ↗ | (On Diff #28022) | Doesn't this duplicate the requiresWorkingCopy() method? |
| scripts/arcanist.php | ||
|---|---|---|
| 209 | What's the reason for if ($vcs_type)? | |
| scripts/arcanist.php | ||
|---|---|---|
| 209 | If a command returns false from requiresWorkingCopy(), but array('git') from getSupportedRevisionControlSystems(), I interpret that to mean that the command can be run either in a Git working copy, or in a directory which is not a VCS working copy. If you run it in a Mercurial working copy, the $vcs_type check allows us to raise an error, which I think is correct. This is somewhat academic because we have no commands like this AFAIK, although it doesn't seem so ridiculous that it defies imagination that we might ever have such commands. | |
| scripts/arcanist.php | ||
|---|---|---|
| 209 | Right, but when would $vcs_type be falsey? | |
Comment Actions
$vcs_type is falsey if you run outside of a working copy, like cd /tmp; arc get-config. That's the root issue here: doing that is currently broken.
Comment Actions
Haha, no problem. It's also confusing that $working_copy really means $working_directory_which_may_also_be_a_repository_working_copy. This is also an unusual use case for regular users of arc.