Paths

Table of Contentst

Differential D11628

Drop explicit version check for flex
ClosedPublic
Actions

Authored by joshuaspence on Feb 2 2015, 9:12 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU2bf861366bea: Drop explicit version check for flex

Summary

I don't really think this is needed anymore. Although there is ~zero cost in keeping this check around, I wouldn't expect anyone to have such an old version of flex installed. According to the flex mailing list, v2.5.33 was released in 2006.

Test Plan

Ran make scanner

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Errors

Severity	Location	Code	Message
Error	support/xhpast/Makefile:24	TXT2	Tab Literal

Unit

No Test Coverage

Build Status

Buildable 4253
Build 4266: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27985.Feb 2 2015, 9:12 PM

joshuaspence retitled this revision from to Drop explicit version check for flex.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 2 2015, 9:12 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

I haven't seen any machines install an old version by default in quite a while.

This revision is now accepted and ready to land.Feb 2 2015, 9:12 PM

Closed by commit rPHU2bf861366bea: Drop explicit version check for flex (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 3 2015, 7:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

support/

xhpast/

Makefile

3 lines

find_flex.sh

Diff 27985

View Options

support/xhpast/Makefile