Page MenuHomePhabricator
Differential D11518

Throw a more tailored exception
ClosedPublic
Actions

Authored by joshuaspence on Jan 27 2015, 10:04 AM.
Tags
None
Referenced Files
F15435583: D11518.id.diff
Tue, Mar 25, 9:03 AM
F15400467: D11518.id27698.diff
Mon, Mar 17, 11:48 AM
F15393133: D11518.diff
Sat, Mar 15, 7:52 PM
Unknown Object (File)
Mar 3 2025, 4:47 PM
Unknown Object (File)
Feb 25 2025, 6:34 AM
Unknown Object (File)
Feb 20 2025, 4:51 AM
Unknown Object (File)
Feb 18 2025, 5:06 PM
Unknown Object (File)
Feb 18 2025, 5:05 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU229cd2667660: Throw a more tailored exception
Summary

Throw a PhutilProxyException instead of a plain old Exception.

Test Plan

N/A

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4077
Build 4090: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27698.Jan 27 2015, 10:04 AM
joshuaspence retitled this revision from to Throw a more tailored exception.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 27 2015, 10:04 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 27 2015, 2:05 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 27 2015, 2:05 PM
Closed by commit rPHU229cd2667660: Throw a more tailored exception (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 27 2015, 7:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
xhpast/
bin/
4 lines

Diff 27698

View Options

src/parser/xhpast/bin/xhpast_parse.php

Loading...
Phabricator · Built by Phacility