Page MenuHomePhabricator
Differential D11518

Throw a more tailored exception
ClosedPublic
Actions

Authored by joshuaspence on Jan 27 2015, 10:04 AM.
Tags
None
Referenced Files
F19095896: D11518.id27720.diff
Dec 4 2025, 7:02 AM
F19003078: D11518.diff
Nov 21 2025, 7:43 AM
F19000104: D11518.id27720.diff
Nov 20 2025, 10:50 PM
F18999226: D11518.id27698.diff
Nov 20 2025, 8:32 PM
F18998774: D11518.diff
Nov 20 2025, 7:30 PM
F18879442: D11518.diff
Nov 6 2025, 6:28 PM
F18783958: D11518.id.diff
Oct 13 2025, 11:09 AM
F18766738: D11518.id27720.diff
Oct 7 2025, 6:16 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU229cd2667660: Throw a more tailored exception
Summary

Throw a PhutilProxyException instead of a plain old Exception.

Test Plan

N/A

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27698.Jan 27 2015, 10:04 AM
joshuaspence retitled this revision from to Throw a more tailored exception.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 27 2015, 10:04 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 27 2015, 2:05 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 27 2015, 2:05 PM
Closed by commit rPHU229cd2667660: Throw a more tailored exception (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 27 2015, 7:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
xhpast/
bin/
4 lines

Diff 27720

View Options

src/parser/xhpast/bin/xhpast_parse.php

Loading...
Phabricator · Built by Phacility