Page MenuHomePhabricator

Make scrolling happen relative to the main content frame
ClosedPublic

Authored by epriestley on Jan 25 2015, 1:42 PM.
Tags
None
Referenced Files
F14077663: D11490.diff
Fri, Nov 22, 12:49 AM
Unknown Object (File)
Wed, Nov 20, 10:30 PM
Unknown Object (File)
Mon, Nov 18, 3:17 AM
Unknown Object (File)
Thu, Nov 14, 10:04 PM
Unknown Object (File)
Thu, Nov 14, 10:47 AM
Unknown Object (File)
Thu, Nov 14, 9:56 AM
Unknown Object (File)
Sun, Nov 10, 1:40 PM
Unknown Object (File)
Tue, Nov 5, 11:42 PM
Subscribers

Details

Summary

Fixes T7033. When we've reframed the main page content we need to scroll relative to the containing frame, not relative to the window.

Test Plan

In Safari, Chrome and Firefox, used j/k/J/K keys to navigate diff content.

Tried some other scroll-based beahviors, like jump-to-anchors.

(It looks like the highlighting reticle got slightly derped a while ago, but it's still functional, so I didn't mess with it.)

Diff Detail

Repository
rP Phabricator
Branch
scrollx6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4034
Build 4047: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Make scrolling happen relative to the main content frame.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 25 2015, 3:35 PM
This revision was automatically updated to reflect the committed changes.