Fixes T7033. When we've reframed the main page content we need to scroll relative to the containing frame, not relative to the window.
Details
Details
- Reviewers
btrahan chad - Maniphest Tasks
- T7033: Keyboard-based browsing of Diffs/Commits/Revisions is broken
- Commits
- Restricted Diffusion Commit
rPea67a8ab8e58: Make scrolling happen relative to the main content frame
In Safari, Chrome and Firefox, used j/k/J/K keys to navigate diff content.
Tried some other scroll-based beahviors, like jump-to-anchors.
(It looks like the highlighting reticle got slightly derped a while ago, but it's still functional, so I didn't mess with it.)
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- scrollx6
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 4034 Build 4047: [Placeholder Plan] Wait for 30 Seconds