Page MenuHomePhabricator
Create Task
Maniphest T7033

Keyboard-based browsing of Diffs/Commits/Revisions is broken
Closed, ResolvedPublic
Actions

Description

Use of the j/k/J/K keyboard shortcuts does not work in many contexts (Chrome 40)

Navigation to a Differential revision, or Diffusion commit, followed by use of the j/k/J/K keys causes a second vertical scrollbar to be created. Mashing the keys causes the second bar to move around, but not the original.

I suspect this has to do with the recent changes to the scrollbar.

Revisions and Commits

rP Phabricator
AuditedD11490rPea67a8ab8e58 Make scrolling happen relative to the main content frame

Related Objects

Event Timeline

epkugelmass created this task.Jan 25 2015, 8:32 AM
epkugelmass raised the priority of this task from to Needs Triage.
epkugelmass updated the task description. (Show Details)
epkugelmass added a subscriber: epkugelmass.
epkugelmass added a project: Google Chrome.Jan 25 2015, 8:37 AM
johnny-bit added a subscriber: johnny-bit.Jan 25 2015, 10:37 AM

I can confirm same behaviour on Firefox 35 on linux when browsing for example D11489

Can be sen on following beforekey/afterkey screenshots:

before_key.png (1×1 px, 111 KB)

after_key.png (1×1 px, 109 KB)

epriestley added a revision: D11490: Make scrolling happen relative to the main content frame.Jan 25 2015, 1:42 PM
epriestley closed this task as Resolved by committing rPea67a8ab8e58: Make scrolling happen relative to the main content frame.Jan 25 2015, 4:42 PM
epriestley added a commit: rPea67a8ab8e58: Make scrolling happen relative to the main content frame.
epriestley added a subscriber: epriestley.Jan 25 2015, 4:47 PM

This should be fixed in HEAD, and on this server. Let us know if you still run into issues. Thanks for the report!

Phabricator · Built by Phacility