Page MenuHomePhabricator

Audit - fix issue "showing older" on some commits
ClosedPublic

Authored by btrahan on Jan 23 2015, 7:31 PM.
Tags
None
Referenced Files
F15443093: D11479.id27610.diff
Thu, Mar 27, 2:18 AM
F15439521: D11479.id.diff
Wed, Mar 26, 7:55 AM
F15436238: D11479.diff
Tue, Mar 25, 12:47 PM
F15434329: D11479.id27610.diff
Tue, Mar 25, 3:02 AM
F15434284: D11479.diff
Tue, Mar 25, 2:53 AM
F15426546: D11479.id27610.diff
Sun, Mar 23, 9:33 AM
F15413169: D11479.id.diff
Wed, Mar 19, 5:21 PM
F15404075: D11479.id27611.diff
Tue, Mar 18, 6:05 AM
Subscribers

Details

Summary

Fixes T7021. When I moved around all the timeline stuff I guess I didn't find this "corner" case, which is wildly common in the post-commit review workflow that we don't use.

Test Plan

pre-patch I could reproduce the issue and post patch I could not. The reproduction case is to have a commit with inline comments and then enough subsequent comments to have a "show older" UI. clicking "show older" now works!

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Audit - fix issue "showing older" on some commits.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 23 2015, 7:31 PM
This revision was automatically updated to reflect the committed changes.