Page MenuHomePhabricator

Audit - fix issue "showing older" on some commits
ClosedPublic

Authored by btrahan on Jan 23 2015, 7:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 5, 7:48 AM
Unknown Object (File)
Mon, Feb 19, 7:29 PM
Unknown Object (File)
Jan 28 2024, 1:48 AM
Unknown Object (File)
Dec 24 2023, 12:46 PM
Unknown Object (File)
Dec 21 2023, 5:43 AM
Unknown Object (File)
Dec 5 2023, 6:13 PM
Unknown Object (File)
Dec 5 2023, 7:16 AM
Unknown Object (File)
Nov 30 2023, 3:05 AM
Subscribers

Details

Summary

Fixes T7021. When I moved around all the timeline stuff I guess I didn't find this "corner" case, which is wildly common in the post-commit review workflow that we don't use.

Test Plan

pre-patch I could reproduce the issue and post patch I could not. The reproduction case is to have a commit with inline comments and then enough subsequent comments to have a "show older" UI. clicking "show older" now works!

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Audit - fix issue "showing older" on some commits.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 23 2015, 7:31 PM
This revision was automatically updated to reflect the committed changes.