Page MenuHomePhabricator

Audit - fix issue "showing older" on some commits
ClosedPublic

Authored by btrahan on Jan 23 2015, 7:31 PM.
Tags
None
Referenced Files
F18194128: D11479.id27611.diff
Sun, Aug 17, 8:40 AM
F18092418: D11479.id.diff
Thu, Aug 7, 10:13 AM
F18092270: D11479.id27610.diff
Thu, Aug 7, 9:12 AM
F18089807: D11479.diff
Wed, Aug 6, 12:43 PM
F18069205: D11479.id27610.diff
Mon, Aug 4, 3:35 PM
F18051328: D11479.id27610.diff
Sun, Aug 3, 10:47 PM
F17999486: D11479.diff
Sat, Aug 2, 6:29 AM
Unknown Object (File)
Jul 5 2025, 7:37 AM
Subscribers

Details

Summary

Fixes T7021. When I moved around all the timeline stuff I guess I didn't find this "corner" case, which is wildly common in the post-commit review workflow that we don't use.

Test Plan

pre-patch I could reproduce the issue and post patch I could not. The reproduction case is to have a commit with inline comments and then enough subsequent comments to have a "show older" UI. clicking "show older" now works!

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Audit - fix issue "showing older" on some commits.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 23 2015, 7:31 PM
This revision was automatically updated to reflect the committed changes.