Page MenuHomePhabricator

Audit - fix issue "showing older" on some commits

Authored by btrahan on Jan 23 2015, 7:31 PM.
Referenced Files
Unknown Object (File)
Feb 19 2023, 10:22 AM
Unknown Object (File)
Feb 17 2023, 9:26 PM
Unknown Object (File)
Feb 5 2023, 3:47 PM
Unknown Object (File)
Feb 4 2023, 1:16 AM
Unknown Object (File)
Feb 1 2023, 3:55 PM
Unknown Object (File)
Feb 1 2023, 3:54 PM
Unknown Object (File)
Dec 29 2022, 2:38 PM
Unknown Object (File)
Dec 28 2022, 10:12 AM



Fixes T7021. When I moved around all the timeline stuff I guess I didn't find this "corner" case, which is wildly common in the post-commit review workflow that we don't use.

Test Plan

pre-patch I could reproduce the issue and post patch I could not. The reproduction case is to have a commit with inline comments and then enough subsequent comments to have a "show older" UI. clicking "show older" now works!

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Audit - fix issue "showing older" on some commits.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 23 2015, 7:31 PM
This revision was automatically updated to reflect the committed changes.